Repository navigation
[No QA] Docs updates for E/A#99527 joining an existing travel billing feed - #100749
Conversation
Co-authored-by: Gandalf <allgandalf@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@RachCHopkins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| description: Turn on Consolidated Travel Billing to centrally pay for employee travel and settle expenses on a recurring schedule. | ||
| keywords: [enable Consolidated Travel Billing, expensify Consolidated Travel Billing setup, central travel billing, workspace travel settings] | ||
| internalScope: Audience is Workspace Admins. Covers enabling Consolidated Travel Billing and initial setup. Does not cover CVV usage, accounting mappings, or exporting statements. | ||
| keywords: [enable Consolidated Travel Billing, expensify Consolidated Travel Billing setup, central travel billing, join existing travel feed, shared travel feed, workspace travel settings] |
There was a problem hiding this comment.
Naming / capitalization: The keyword expensify Consolidated Travel Billing setup uses lowercase expensify. Per HELPSITE_NAMING_CONVENTIONS.md (match capitalization exactly) and the feature-name guidance in HELP_AUTHORING_GUIDELINES.md, use Expensify.
| @@ -35,11 +35,28 @@ If a bank account is not set up, you’ll be prompted to add one during setup. | |||
| 3. Select your Workspace. | |||
| 4. In the Workspace settings, click **Travel**. | |||
| 5. In the **Consolidated Travel Billing** section, switch the toggle to enabled. | |||
There was a problem hiding this comment.
Step formatting: This numbered step bundles a conditional and two separate actions ("a list appears" + "select a feed" + "or select Set up a new travel feed") into one step. Per HELP_AUTHORING_GUIDELINES.md Section 5, steps should be sequential and single-action. Consider splitting the two choices into sub-actions or separate steps so the branch is scannable.
| ## How to join an existing Consolidated Travel Billing feed | ||
|
|
||
| If another Workspace at your company already has Consolidated Travel Billing set up, this Workspace can join that feed instead of creating its own. When you switch the toggle on, Expensify shows the feeds you can join. | ||
|
|
There was a problem hiding this comment.
Accuracy / deterministic writing: This states the shared feed puts spend on "the same monthly bill", but the article elsewhere describes settlement frequency as variable ("selected settlement frequency (for example, monthly)"). Asserting "monthly" here contradicts that and could mislead. Use the general "settlement schedule/frequency" wording for consistency (HELPSITE_NAMING_CONVENTIONS.md Deterministic Writing Rule).
| --- | ||
|
|
||
| ## How to join an existing Consolidated Travel Billing feed | ||
|
|
There was a problem hiding this comment.
Deterministic writing / consistency: This describes the same toggle as "switch the toggle on", while step 5 above uses "switch the toggle to enabled". Per HELPSITE_NAMING_CONVENTIONS.md (be consistent, avoid stylistic variation), use one consistent phrasing for the toggle action throughout the article.
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.90-0 🚀
|
|
@blimpich @stephanieelliott Ok to check off if no need QA? |
|
Yes |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.90-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Help site follow-up for #99527, which lets a Workspace join an existing Consolidated Travel Billing feed on the domain instead of always provisioning its own.
docs/articles/travel/consolidated-travel-billing/Enable-Consolidated-Travel-Billing-in-a-Workspace.mdpreviously described only one path after switching the toggle on: add or select a settlement bank account. That is now the fallback path. When the admin already administers a configured travel feed, a feed list opens first, with a Set up a new travel feed option at the bottom.Changes:
keywordsandinternalScopemetadata to cover the joining workflow.<!-- SCREENSHOT: -->suggestion for the feed list, per the authoring guidelines.Applied
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: one#title plus# FAQ, task-based##headings, bolded UI labels in Sentence case, relative cross-links only.UI label verification:
Travel(workspace settings row, under Spend in More features) was confirmed live in the web app.Consolidated Travel BillingandSet up a new travel feedwere confirmed againstsrc/languages/en.tson the head branch — the section is gated behind Expensify Travel's business-verification flow, which the test account cannot complete, so those two strings were not observed rendered. Please confirm them.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/662524
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
Offline tests
N/A — documentation only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@allgandalf, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.