Skip to content

[No QA] Docs updates for E/A#99527 joining an existing travel billing feed - #100749

Merged
blimpich merged 1 commit into
mainfrom
claude-docsTravelBillingSharedFeed
Sep 18, 2026
Merged

blimpich merged 1 commit into
mainfrom
claude-docsTravelBillingSharedFeed

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for #99527, which lets a Workspace join an existing Consolidated Travel Billing feed on the domain instead of always provisioning its own.

docs/articles/travel/consolidated-travel-billing/Enable-Consolidated-Travel-Billing-in-a-Workspace.md previously described only one path after switching the toggle on: add or select a settlement bank account. That is now the fallback path. When the admin already administers a configured travel feed, a feed list opens first, with a Set up a new travel feed option at the bottom.

Changes:

  • Added the feed-selection step to How to enable Consolidated Travel Billing in a Workspace and renumbered the steps that follow.
  • Added a How to join an existing Consolidated Travel Billing feed section explaining both branches, including that joining a feed reuses that feed's settlement account so no bank account is requested.
  • Added two FAQ entries: sharing one feed across two Workspaces, and why no feeds appear in the list.
  • Updated keywords and internalScope metadata to cover the joining workflow.
  • Added a <!-- SCREENSHOT: --> suggestion for the feed list, per the authoring guidelines.

Applied docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md: one # title plus # FAQ, task-based ## headings, bolded UI labels in Sentence case, relative cross-links only.

UI label verification: Travel (workspace settings row, under Spend in More features) was confirmed live in the web app. Consolidated Travel Billing and Set up a new travel feed were confirmed against src/languages/en.ts on the head branch — the section is gated behind Expensify Travel's business-verification flow, which the test account cannot complete, so those two strings were not observed rendered. Please confirm them.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/662524
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"

  • Verify that no errors appear in the JS console

Offline tests

N/A — documentation only.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@allgandalf, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Gandalf <allgandalf@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 9, 2026 19:56
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 9, 2026
@MelvinBot MelvinBot mentioned this pull request Sep 9, 2026
40 tasks done
@allgandalf allgandalf removed their assignment Sep 10, 2026
@blimpich
blimpich marked this pull request as ready for review September 18, 2026 15:59
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-09-18T16:29:27.036841Z d088e2a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot

melvin-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @RachCHopkins

@melvin-bot
melvin-bot Bot requested a review from RachCHopkins September 18, 2026 15:59
@melvin-bot

melvin-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

@RachCHopkins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 18, 2026 15:59
description: Turn on Consolidated Travel Billing to centrally pay for employee travel and settle expenses on a recurring schedule.
keywords: [enable Consolidated Travel Billing, expensify Consolidated Travel Billing setup, central travel billing, workspace travel settings]
internalScope: Audience is Workspace Admins. Covers enabling Consolidated Travel Billing and initial setup. Does not cover CVV usage, accounting mappings, or exporting statements.
keywords: [enable Consolidated Travel Billing, expensify Consolidated Travel Billing setup, central travel billing, join existing travel feed, shared travel feed, workspace travel settings]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming / capitalization: The keyword expensify Consolidated Travel Billing setup uses lowercase expensify. Per HELPSITE_NAMING_CONVENTIONS.md (match capitalization exactly) and the feature-name guidance in HELP_AUTHORING_GUIDELINES.md, use Expensify.

@@ -35,11 +35,28 @@ If a bank account is not set up, you’ll be prompted to add one during setup.
3. Select your Workspace.
4. In the Workspace settings, click **Travel**.
5. In the **Consolidated Travel Billing** section, switch the toggle to enabled.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step formatting: This numbered step bundles a conditional and two separate actions ("a list appears" + "select a feed" + "or select Set up a new travel feed") into one step. Per HELP_AUTHORING_GUIDELINES.md Section 5, steps should be sequential and single-action. Consider splitting the two choices into sub-actions or separate steps so the branch is scannable.

## How to join an existing Consolidated Travel Billing feed

If another Workspace at your company already has Consolidated Travel Billing set up, this Workspace can join that feed instead of creating its own. When you switch the toggle on, Expensify shows the feeds you can join.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accuracy / deterministic writing: This states the shared feed puts spend on "the same monthly bill", but the article elsewhere describes settlement frequency as variable ("selected settlement frequency (for example, monthly)"). Asserting "monthly" here contradicts that and could mislead. Use the general "settlement schedule/frequency" wording for consistency (HELPSITE_NAMING_CONVENTIONS.md Deterministic Writing Rule).

---

## How to join an existing Consolidated Travel Billing feed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deterministic writing / consistency: This describes the same toggle as "switch the toggle on", while step 5 above uses "switch the toggle to enabled". Per HELPSITE_NAMING_CONVENTIONS.md (be consistent, avoid stylistic variation), use one consistent phrasing for the toggle action throughout the article.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR extends the existing Consolidated Travel Billing article to document the new join-an-existing-feed workflow from Expensify/App issue 99527. It adds a feed-selection step, a task-based section explaining both branches, two FAQ entries, an updated metadata block, and a screenshot suggestion. The additions are well-scoped, consistent with the existing article, and closely aligned with the governance files.

Scores Summary

  • Readability: 9/10 - Clear, scannable prose. The new step slots cleanly into the numbered flow with correct renumbering, and the branch explanation uses concise bullets that distinguish the two paths well.
  • AI Readiness: 9/10 - The new 'How to join an existing Consolidated Travel Billing feed' heading is task-based and uses the full feature name. keywords and internalScope were updated to cover the joining workflow and real search phrases. Heading hierarchy stays within the top two levels only.
  • Style Compliance: 9/10 - UI labels bolded in Sentence case (Set up a new travel feed, Travel, Consolidated Travel Billing section). New FAQ entries are question-based and correctly placed under the existing FAQ heading. Cross-link is relative with descriptive anchor text.

Key Findings

  • Metadata updates are meaningful, not cosmetic: internalScope now names the joining-an-existing-feed workflow and keywords adds realistic phrases (join existing travel feed, shared travel feed).
  • The new section correctly explains both branches (join vs set up new) and the important consequence that joining reuses the existing settlement account, so no bank account is requested.
  • Screenshot suggestion follows the required HTML-comment format with a specific Purpose tied to a concrete member confusion (admins not recognizing the feed list). Compliant with Section 8.
  • The two new FAQ entries are question-based, concise, and sit under the single existing FAQ heading; heading rules preserved.
  • Single-workflow focus is maintained; the joining path is a branch of the same enable workflow rather than scope creep.

Recommendations

  • Confirm the live UI strings before merge. The PR description notes that Consolidated Travel Billing and Set up a new travel feed were verified against src/languages/en.ts but could not be observed rendered (gated behind business verification). Governance requires exact UI text, so a live confirmation of the feed-list label and the button is the one outstanding item.
  • Minor: watch for trailing whitespace after the settlement step on the renumbered step 7 (carried over from the original line).

Files Reviewed

  • docs/articles/travel/consolidated-travel-billing/Enable-Consolidated-Travel-Billing-in-a-Workspace.md - Additions compliant with authoring, naming, and template governance; pending live UI-string confirmation.

Note: Detailed line-by-line feedback has been provided as inline comments.

@blimpich
blimpich merged commit c5b876a into main Sep 18, 2026
18 of 19 checks passed
@blimpich
blimpich deleted the claude-docsTravelBillingSharedFeed branch September 18, 2026 16:34
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.90-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@izarutskaya

Copy link
Copy Markdown

@blimpich @stephanieelliott Ok to check off if no need QA?

@blimpich

Copy link
Copy Markdown
Contributor

Yes

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.90-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@stephanieelliott stephanieelliott changed the title Docs updates for E/A#99527 joining an existing travel billing feed [No QA] Docs updates for E/A#99527 joining an existing travel billing feed Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants